Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use variable to refer to Emscripten when linking #3854

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Use variable to refer to Emscripten when linking #3854

merged 1 commit into from
Dec 22, 2023

Conversation

randombit
Copy link
Owner

This allows overriding the path to emscripten using CXX and having it work consistently.

GH #3836

@randombit
Use variable to refer to Emscripten when linking
95170e9 
This allows overriding the path to emscripten using CXX and
having it work consistently.

GH #3836
@coveralls
Copy link

Coverage Status

coverage: 92.057% (-0.01%) from 92.07%
when pulling 95170e9 on jack/fix-emcc-link
into 3ff4753 on master.

@reneme reneme self-requested a review December 22, 2023 16:06
reneme
reneme approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know!

@randombit randombit merged commit c314d7f into master Dec 22, 2023
39 checks passed
@randombit randombit deleted the jack/fix-emcc-link branch December 22, 2023 18:05
@reneme reneme mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneme reneme reneme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randombit @coveralls @reneme