Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig algos and key agreements to bench.py #3829

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

securitykernel
Copy link
Collaborator

Extends bench.py in order to be ready to run comparative benchmarks against OpenSSL to be published.

  • From the already supported algorithms, remove MD5 and RIPEMD and add SHA-3 instead
  • Add signature algorithms, in particular RSA and ECDSA (more can be added easily)
  • Add key agreements, in particular DH and ECDH (more can be added easily)

Tested successfully with OpenSSL 3.0 and 3.2. OpenSSL seems to have changed their machine-readable output format in between these versions, which forced us to make the regexs more flexible.

Also changed the DH groups used in botan speed dh from modp to ffdhe, because the latter is used by openssl speed. Had to remove some key sizes not supported by the FFDHE groups.

bench.py now also supports optionally specifying one or more algorithms to benchmark instead of benchmarking all algorithms from the internal lists:

src/scripts/bench.py # still the default: benchmark all algorithms
src/scripts/bench.py RSA # NEW: benchmark only RSA
src/scripts/bench.py RSA ECDSA AES-128/GCM # NEW: benchmark RSA, ECDSA and AES-128/GCM

@securitykernel securitykernel self-assigned this Dec 11, 2023
Copy link
Owner

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@coveralls
Copy link

coveralls commented Dec 11, 2023

Coverage Status

coverage: 92.069% (+0.003%) from 92.066%
when pulling 7bd651a on sk/more-benchmarks
into 2bcccc8 on master.

@securitykernel securitykernel merged commit 170a735 into master Dec 11, 2023
38 checks passed
@securitykernel securitykernel deleted the sk/more-benchmarks branch December 11, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants