FIX: Non-KEX-algos may choose to not implement ::generate_another() #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
approved these changes
Oct 31, 2023
src/lib/pubkey/pk_keys.h
Outdated
| * same algorithm parameters as this key. | ||
| * same algorithm parameters as this key. This is most useful for algorithms | ||
| * that support PublicKeyOperation::KeyAgreement to generate a fitting ephemeral | ||
| * key pair. For other key types it might throw NotImplemented. |
Some algorithms (like HSS/LMS) cannot even implement it at all, because their public key does not provide enough information about the private key's internal parameters.
reneme
force-pushed
the
fix/allow_not_implementing_generate_another
branch
from
18f2275 to
87bcc79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some algorithms (like HSS/LMS #3716) cannot even implement it at all, because their public key does not provide enough information about the private key's internal parameters.