-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce <botan/boost_compat.h> as feature flag #3765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of minor comments (and I concur on the comments @lieser left) but basically LGTM.
Can you please amend the relevant docs/examples?
* as of Botan 3.3.0 | ||
* 1.73.0 - first version supporting the C++20 concepts syntax | ||
*/ | ||
#define BOTAN_MINIMUM_SUPPORTED_BOOST_VERSION 107300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should be clarified that it only applies to the asio integrations; we can still use older Boost for eg socket wrappers.
8eaa184
to
bdb44d8
Compare
I applied the suggestions, extended |
This introduces
#include <botan/boost_compat.h>
that definesBOTAN_MINIMUM_SUPPORTED_BOOST_VERSION
as the minimum version of boost to be usable by this version of Botan. If the available boost headers are new enough,BOTAN_FOUND_COMPATIBLE_BOOST_VERSION
is defined as well. In this case, it is safe to#include <botan/asio_stream.h>
, otherwise a macro-error would be generated.Usage example: