Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of buffer_insert from filters, MACs, stream ciphers #3757

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Remove use of buffer_insert from filters, MACs, stream ciphers #3757

merged 2 commits into from
Oct 13, 2023

Conversation

randombit
Copy link
Owner

No description provided.

@randombit randombit force-pushed the jack/remove-buffer-insert branch from 49d3d24 to e7419bc Compare October 13, 2023 10:39
reneme
reneme approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this looks fine to me. Though, I feel, we could utilize AlignmentBuffer<> for some of those places.

@randombit
Copy link
Owner Author

Generally this looks fine to me. Though, I feel, we could utilize AlignmentBuffer<> for some of those places.

I do not disagree! This PR sequence is just about removing buffer_insert and a few of the other relatively obscure functions from mem_ops.h to make further refactorings there easier.

@reneme
Copy link
Collaborator

reneme commented Oct 13, 2023 •
edited
Loading

Whoops! 😨 I took the liberty to apply AlignmentBuffer<> to Poly1305 to verify my own claim. Feel free to purge my commit from this PR, if we want to keep things clean.

@randombit
Copy link
Owner Author

No worries, that is even better. I was just going for minimum possible refactoring at this stage.

@randombit randombit merged commit 380b3ca into master Oct 13, 2023
@randombit randombit deleted the jack/remove-buffer-insert branch October 13, 2023 21:12
@randombit randombit mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneme reneme reneme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randombit @reneme