Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing simd requires to aes_ni #3741

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

lieser
Copy link
Collaborator

@lieser lieser commented Oct 9, 2023

No description provided.

@lieser lieser added this to the Botan 3.2.0 milestone Oct 9, 2023
@lieser lieser requested a review from reneme October 9, 2023 09:34
@lieser lieser self-assigned this Oct 9, 2023
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've stumbled over that recently as well, while working on the module dependencies of FrodoKEM (#3679). You beat me to submitting a fix. Thanks.

@randombit
Copy link
Owner

Thanks!

BTW if unaware, there is a script that is helpful for detecting issues like this - src/scripts/test_all_configs.py which tries to do a build and optionally run the tests in two modes - a build with any single module disabled, and also minimized builds with exactly one named module included. I only run it occasionally, and always on very big machines. I think it would be to slow even for a nightly job given just 2 cores, but maybe we could adapt some variation of this idea for a nightly.

@randombit randombit merged commit 335af74 into master Oct 9, 2023
37 checks passed
@randombit randombit deleted the pl/fix_missing_simd_requires branch October 9, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants