CI: Test nightly Hybrid PQ/T TLS interoperability #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneme
commented
Oct 9, 2023
reneme
force-pushed
the
ci/test_nightly_pq_tls
branch
from
b0374fe to
747c5f1
Compare
reneme
commented
Oct 9, 2023
Comment on lines
+15
to
+19
| push: | ||
| paths: | ||
| # Run if a pull request changes this workflow to | ||
| # validate it works properly before merging. | ||
| - '.github/workflows/nightly.yml' |
There was a problem hiding this comment.
This doesn't seem to work. My suspicion is that this configuration takes effect only once it was merged. I.e. with the next change to nightly.yml. Though, admittedly that might be wishful thinking.
There was a problem hiding this comment.
I guess the easiest thing to do is just to merge this and then open a test PR that tries modifying it and see if it works.
Tests are run against (beta) services of Cloudflare, IBM, Google and OpenQuantumSafe
reneme
force-pushed
the
ci/test_nightly_pq_tls
branch
from
747c5f1 to
d341ca6
Compare
randombit
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a nightly job to run the PQ/T interoperability tests against online (beta) services. We don't do that on normal CI runs to avoid introducing a(nother) direct dependency to 3rd party services there.