Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to disable internal modules #3489

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

randombit
Copy link
Owner

Fixes #3488

@randombit randombit requested a review from reneme April 9, 2023 23:25
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (3a2b906) 88.20% compared to head (df2a0df) 88.19%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
- Coverage   88.20%   88.19%   -0.02%     
==========================================
  Files         617      617              
  Lines       70417    70415       -2     
  Branches     6888     6887       -1     
==========================================
- Hits        62109    62099      -10     
- Misses       5448     5454       +6     
- Partials     2860     2862       +2     

see 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

@randombit randombit merged commit 0150a2b into master Apr 10, 2023
@randombit randombit deleted the jack/disabling-internal-is-fine branch April 11, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./configure.py --disable-modules=tls fails
3 participants