Use std::string_view and fmt more extensively #3480
Conversation
randombit
force-pushed
the
jack/more-fmt
branch
6 times, most recently
from
0a37e79 to
c661721
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #3480 +/- ##
==========================================
+ Coverage 88.20% 88.21% +0.01%
==========================================
Files 617 617
Lines 70417 70387 -30
Branches 6888 6822 -66
==========================================
- Hits 62109 62095 -14
+ Misses 5448 5436 -12
+ Partials 2860 2856 -4
... and 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| { | ||
| return m_name; | ||
| } | ||
|
|
||
| const std::string& hash_function_name() const | ||
| const std::string hash_function_name() const |
There was a problem hiding this comment.
Sorry for pulling out this old PR. Though: I think these should have stayed const std::string&, no?
There was a problem hiding this comment.
I don't recall what my thinking was here. If I had to guess, this was an accident where I had a regex converting s/const std::string&/std::string_view/g, and then I reverted cases like here where I was changing a return type, but then failed to fully revert.
No description provided.