Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erronous check on RSA-PSS certificates #3421

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

randombit
Copy link
Owner

Fixes #3019

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 77.77% and project coverage change: -0.04 ⚠️

Comparison is base (d8db5f2) 88.17% compared to head (cc621da) 88.14%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3421      +/-   ##
==========================================
- Coverage   88.17%   88.14%   -0.04%     
==========================================
  Files         619      619              
  Lines       70296    70295       -1     
  Branches     6995     6992       -3     
==========================================
- Hits        61986    61962      -24     
- Misses       5386     5420      +34     
+ Partials     2924     2913      -11     
Impacted Files Coverage Δ
src/lib/x509/x509cert.cpp 73.50% <ø> (+0.02%) ⬆️
src/tests/unit_x509.cpp 93.84% <77.77%> (-0.19%) ⬇️

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@randombit randombit merged commit 319c701 into master Mar 24, 2023
@randombit randombit deleted the jack/fix-rsa-pss branch March 24, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X509_Certificate fails to parse a RSA-PSS certificate that was not signed by another RSA-PSS cert
2 participants