Kyber Encoding Improvements #3411
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #3411 +/- ##
==========================================
+ Coverage 88.20% 88.21% +0.01%
==========================================
Files 618 618
Lines 70477 70331 -146
Branches 7001 6994 -7
==========================================
- Hits 62161 62041 -120
+ Misses 5387 5357 -30
- Partials 2929 2933 +4
... and 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
|
||
| Kyber_PublicKey(const AlgorithmIdentifier& alg_id, | ||
| const std::vector<uint8_t>& key_bits); | ||
| std::span<const uint8_t> key_bits); |
There was a problem hiding this comment.
It would be nice to make this change for all of the key types before 3.0
(This is the sort of minor thing that can be done after the RC)
Left a comment in #3318
This removes the half-baked DER encoding from Kyber (see #3328). Also it reduces copies and code complexity in Kyber's parsing code. The two changes are in individual commits.