Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dilithium verification #3368

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Fix Dilithium verification #3368

merged 1 commit into from
Mar 14, 2023

Conversation

randombit
Copy link
Owner

GH #3367

@randombit randombit merged commit f471186 into master Mar 14, 2023
reneme
reneme approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲

The speed test did try multiple verifications before, right?

@randombit
Copy link
Owner Author

randombit commented Mar 14, 2023 •
edited
Loading

Yes! And it used a cached PK_Verifier. Nothing has changed here in at least two weeks. And the most baffling part is, of course it never worked correctly - I can check out a revision from last week, and it fails for me on my local machine. And yet CI passed this entire time, and the CLI test script checks the output against a regex that the error message does not match. I have no idea what happened here, and I don't like it.

@randombit randombit deleted the jack/fix-dilithium-verification branch March 14, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneme reneme reneme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randombit @reneme