Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds overloads for
std::span<>
to the TLS channel API: NamelyTLS::Channel::received_data()
and::send()
. Internally, those are now dispatched to the new (virtual) protected methods::from_peer()
and::to_peer()
. Subclasses of the basic TLS channel now overload those. The ptr-length style overloads of::received_data()
and::send()
are left intact.The
TLS::Callbacks::tls_emit_data()
andTLS::Callbacks::tls_record_received()
now usestd::span<>
as well. This is not backward compatible, unfortunately. The migration guide has been adapted accordingly.Also, the TLS 1.3 implementation is adapted slightly to push the
std::span<>
deeper into layers. More adaptions are left for future work.