Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::span/std::string_view for base64 codec #3350

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

reneme
Copy link
Collaborator

@reneme reneme commented Mar 5, 2023

Code signing will come later.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 20.00% and project coverage change: -0.04 ⚠️

Comparison is base (63434bb) 88.16% compared to head (bca7ef6) 88.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
- Coverage   88.16%   88.13%   -0.04%     
==========================================
  Files         615      615              
  Lines       69987    69994       +7     
  Branches     6949     6950       +1     
==========================================
- Hits        61702    61687      -15     
- Misses       5385     5401      +16     
- Partials     2900     2906       +6     
Impacted Files Coverage Δ
src/lib/codec/base64/base64.cpp 92.59% <20.00%> (-4.82%) ⬇️
src/lib/utils/thread_utils/semaphore.cpp 45.45% <0.00%> (-54.55%) ⬇️
src/lib/pbkdf/argon2/argon2pwhash.cpp 69.69% <0.00%> (-9.10%) ⬇️
src/fuzzer/barrett.cpp 66.66% <0.00%> (-5.56%) ⬇️
src/fuzzer/mode_padding.cpp 90.90% <0.00%> (-3.74%) ⬇️
src/lib/pubkey/elgamal/elgamal.cpp 84.93% <0.00%> (-1.37%) ⬇️
src/lib/pubkey/dl_group/dl_group.cpp 84.78% <0.00%> (-0.68%) ⬇️
src/lib/ffi/ffi.cpp 76.15% <0.00%> (-0.67%) ⬇️
src/lib/math/numbertheory/numthry.cpp 83.90% <0.00%> (-0.49%) ⬇️
src/tests/test_bigint.cpp 90.86% <0.00%> (+0.02%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@reneme reneme merged commit 7b1b55c into master Mar 6, 2023
@randombit randombit deleted the span/base64_codec branch March 6, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants