Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android can possibly support arc4random API. #1851

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

devnexen
Copy link
Collaborator

@devnexen devnexen commented Mar 7, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #1851 into master will increase coverage by 1.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1851      +/-   ##
=========================================
+ Coverage    90.1%   91.4%   +1.29%     
=========================================
  Files         527     527              
  Lines       55964   55964              
  Branches     5830    5830              
=========================================
+ Hits        50426   51153     +727     
+ Misses       5538    4811     -727
Impacted Files Coverage Δ
src/lib/rng/stateful_rng/stateful_rng.cpp 88.88% <0%> (-3.71%) ⬇️
src/lib/pubkey/dl_group/dl_group.cpp 91.33% <0%> (-1.19%) ⬇️
src/tests/test_ffi.cpp 99.79% <0%> (+0.06%) ⬆️
src/cli/speed.cpp 90.75% <0%> (+0.21%) ⬆️
src/lib/stream/chacha/chacha.cpp 100% <0%> (+0.93%) ⬆️
src/lib/hash/sha2_64/sha2_64.cpp 100% <0%> (+1.11%) ⬆️
src/lib/pubkey/mce/mceliece_key.cpp 86.51% <0%> (+1.12%) ⬆️
src/lib/hash/sha2_32/sha2_32.cpp 98.63% <0%> (+1.36%) ⬆️
src/lib/hash/sha3/sha3.cpp 100% <0%> (+1.44%) ⬆️
src/lib/block/threefish_512/threefish_512.cpp 100% <0%> (+3.12%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9252df3...1da939d. Read the comment docs.

@randombit
Copy link
Owner

I could not figure out exactly which Android version added support for arc4random but it seems to be at least 4.3 which is old enough that we don't need to care about anything earlier.

@randombit randombit merged commit 1da939d into randombit:master Mar 9, 2019
randombit added a commit that referenced this pull request Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants