fixed review items

randombit · Jun 13, 2023 · d1a15ea · d1a15ea
1 parent a97a58d
commit d1a15ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/lib/hash/sha3/keccak_fips.cpp b/src/lib/hash/sha3/keccak_fips.cpp
@@ -134,7 +134,7 @@ Keccak_FIPS::Keccak_FIPS(size_t output_bits, size_t capacity, uint64_t custom_pa
       m_S(25),  // 1600 bit
       m_S_pos(0) {
    // We only support the parameters for Keccak-FIPS in this constructor
-
+   BOTAN_ASSERT_NOMSG(output_bits % 8 == 0);
    if(output_bits > 1600)
       throw Invalid_Argument("Keccak_FIPS: Invalid output length " + std::to_string(output_bits));
 }

diff --git a/src/lib/hash/sha3/keccak_fips.h b/src/lib/hash/sha3/keccak_fips.h
@@ -51,15 +51,16 @@ class Keccak_FIPS final {
 
       uint32_t bit_rate() const { return m_bitrate; }
 
-      std::string name() const;
       void clear();
       std::string provider() const;
 
-      secure_vector<uint64_t>& get_internal_state() { return m_S; }
+      secure_vector<uint64_t>& internal_state() { return m_S; }
+
+      const secure_vector<uint64_t>& internal_state() const { return m_S; }
 
       void set_internal_pos(uint32_t pos) { m_S_pos = pos; }
 
-      uint32_t get_internal_pos() { return m_S_pos; }
+      uint32_t internal_pos() { return m_S_pos; }
 
       // Static functions for internal usage