Inline asm bug? GCC bug? The world may never know

randombit · Apr 10, 2024 · b95c51f · b95c51f
1 parent fcba650
commit b95c51f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/lib/math/mp/mp_asmi.h b/src/lib/math/mp/mp_asmi.h
@@ -217,7 +217,7 @@ template <WordType W>
 inline constexpr auto word8_add3(W z[8], const W x[8], const W y[8], W carry) -> W {
 #if defined(BOTAN_MP_USE_X86_64_ASM)
    if(std::same_as<W, uint64_t> && !std::is_constant_evaluated()) {
-      asm(ADD_OR_SUBTRACT(DO_8_TIMES(ADDSUB3_OP, "adcq"))
+      asm volatile(ADD_OR_SUBTRACT(DO_8_TIMES(ADDSUB3_OP, "adcq"))
           : [carry] "=r"(carry)
           : [x] "r"(x), [y] "r"(y), [z] "r"(z), "0"(carry)
           : "cc", "memory");
@@ -317,7 +317,7 @@ template <WordType W>
 inline constexpr auto word8_sub3(W z[8], const W x[8], const W y[8], W carry) -> W {
 #if defined(BOTAN_MP_USE_X86_64_ASM)
    if(std::same_as<W, uint64_t> && !std::is_constant_evaluated()) {
-      asm(ADD_OR_SUBTRACT(DO_8_TIMES(ADDSUB3_OP, "sbbq"))
+      asm volatile(ADD_OR_SUBTRACT(DO_8_TIMES(ADDSUB3_OP, "sbbq"))
           : [carry] "=r"(carry)
           : [x] "r"(x), [y] "r"(y), [z] "r"(z), "0"(carry)
           : "cc", "memory");