fix wrong doxygen comments

src/lib/pubkey/hss_lms/hss.h

@@ -129,7 +129,6 @@ class BOTAN_TEST_API HSS_LMS_PrivateKeyInternal final {
        *
        * @param hss_params The HSS-LMS parameters for the key.
        * @param rng The rng to use.
-       * @return The internal HSS-LMS private key.
        */
       HSS_LMS_PrivateKeyInternal(const HSS_LMS_Params& hss_params, RandomNumberGenerator& rng);
 
@@ -171,8 +170,6 @@ class BOTAN_TEST_API HSS_LMS_PrivateKeyInternal final {
        * if applications create multiple signatures in one go.
        *
        * @param msg The message to sign.
-       * @param rng The rng to use.
-       * @return The HSS-LMS signature.
        */
       secure_vector<uint8_t> sign(std::span<const uint8_t> msg);
 
@@ -215,7 +212,7 @@ class BOTAN_TEST_API HSS_LMS_PrivateKeyInternal final {
        *
        * We use the same generation as the reference implementation (https://github.com/cisco/hash-sigs).
        *
-       * @param child_lms_params The LMS parameters of the child tree.
+       * @param child_lms_lmots_params The LMS-LMOTS parameter pair of the child tree.
        * @param parent_sk The parent's LMS private key
        * @param parent_q The LMS leaf number the child tree has in its parent tree.
        * @return LMS private key

src/lib/pubkey/hss_lms/lms.h

@@ -222,7 +222,7 @@ class BOTAN_TEST_API LMS_PublicKey : public LMS_Instance {
       /**
        * @brief Parse a public LMS key.
        *
-       * @param key_bytes The public key bytes to parse.
+       * @param slicer The BufferSlicer at the public key bytes' position
        * @return The LMS public key.
        * @throws Decoding_Error If parsing the public key fails.
        */

src/scripts/dev_tools/run_clang_tidy.py

@@ -30,6 +30,7 @@
     'cert-*',
     'clang-analyzer-*',
     'cppcoreguidelines-*',
+    'clang-diagnostic-*',
     'hicpp-*',
     'misc-*',
     'modernize-*',
@@ -46,6 +47,7 @@
     'bugprone-lambda-function-name', # should be an easy fix
     'bugprone-unchecked-optional-access', # clang-tidy seems buggy (many false positives)
     'cert-err58-cpp', # many false positives eg __m128i
+    'cppcoreguidelines-avoid-do-while',
     'cppcoreguidelines-init-variables',
     'cppcoreguidelines-owning-memory',
     'cppcoreguidelines-prefer-member-initializer',
@@ -91,6 +93,7 @@
     'hicpp-vararg', # idiocy
     'hicpp-signed-bitwise', # impossible to avoid in C/C++, int promotion rules :/
     'misc-no-recursion',
+    'misc-include-cleaner',
     'modernize-loop-convert', # sometimes very ugly
     'modernize-raw-string-literal', # usually less readable
     'modernize-use-trailing-return-type', # fine, but we're not using it everywhere