Merge pull request #4024 from Rohde-Schwarz/refactor/crystals_april

Refactor: Have a common base for Kyber/Dilithium structures
randombit · Jul 15, 2024 · 2fe687b · 2fe687b
2 parents 55007af + 8bd26c7
commit 2fe687b
Show file tree

Hide file tree

Showing 43 changed files with 4,224 additions and 3,027 deletions.
diff --git a/src/lib/pubkey/dilithium/dilithium/dilithium_modern.h b/src/lib/pubkey/dilithium/dilithium/dilithium_modern.h
@@ -12,7 +12,6 @@
 #include <botan/internal/dilithium_symmetric_primitives.h>
 
 #include <botan/internal/loadstor.h>
-#include <botan/internal/shake.h>
 #include <botan/internal/shake_xof.h>
 
 #include <array>
@@ -23,26 +22,30 @@ namespace Botan {
 
 class Dilithium_Common_Symmetric_Primitives : public Dilithium_Symmetric_Primitives {
    public:
-      std::unique_ptr<Botan::XOF> XOF(XofType type, std::span<const uint8_t> seed, uint16_t nonce) const override {
-         const auto xof_type = [&] {
+      Dilithium_Common_Symmetric_Primitives(size_t collision_strength_in_bytes) :
+            Dilithium_Symmetric_Primitives(collision_strength_in_bytes) {}
+
+      Botan::XOF& XOF(XofType type, std::span<const uint8_t> seed, uint16_t nonce) const override {
+         auto& xof = [&]() -> Botan::XOF& {
             switch(type) {
                case XofType::k128:
-                  return "SHAKE-128";
+                  return m_xof_128;
                case XofType::k256:
-                  return "SHAKE-256";
+                  return m_xof_256;
             }
 
             BOTAN_ASSERT_UNREACHABLE();
          }();
 
-         std::array<uint8_t, sizeof(nonce)> nonce_buffer;
-         store_le(nonce, nonce_buffer.data());
-
-         auto xof = Botan::XOF::create_or_throw(xof_type);
-         xof->update(seed);
-         xof->update(nonce_buffer);
+         xof.clear();
+         xof.update(seed);
+         xof.update(store_le(nonce));
          return xof;
       }
+
+   private:
+      mutable SHAKE_256_XOF m_xof_256;
+      mutable SHAKE_128_XOF m_xof_128;
 };
 
 }  // namespace Botan

diff --git a/src/lib/pubkey/dilithium/dilithium_aes/dilithium_aes.h b/src/lib/pubkey/dilithium/dilithium_aes/dilithium_aes.h
@@ -22,8 +22,11 @@ namespace Botan {
 
 class Dilithium_AES_Symmetric_Primitives : public Dilithium_Symmetric_Primitives {
    public:
+      Dilithium_AES_Symmetric_Primitives(size_t collision_strength_in_bytes) :
+            Dilithium_Symmetric_Primitives(collision_strength_in_bytes) {}
+
       // AES mode always uses AES-256, regardless of the XofType
-      std::unique_ptr<Botan::XOF> XOF(XofType /* type */, std::span<const uint8_t> seed, uint16_t nonce) const final {
+      Botan::XOF& XOF(XofType /* type */, std::span<const uint8_t> seed, uint16_t nonce) const final {
          // Algorithm Spec V. 3.1 Section 5.3
          //    In the AES variant, the first 32 bytes of rhoprime are used as
          //    the key and i is extended to a 12 byte nonce for AES-256 in
@@ -36,10 +39,13 @@ class Dilithium_AES_Symmetric_Primitives : public Dilithium_Symmetric_Primitives
          const std::array<uint8_t, 12> iv{get_byte<1>(nonce), get_byte<0>(nonce), 0};
          const auto key = seed.first(32);
 
-         auto xof = std::make_unique<AES_256_CTR_XOF>();
-         xof->start(iv, key);
-         return xof;
+         m_aes_xof.clear();
+         m_aes_xof.start(iv, key);
+         return m_aes_xof;
       }
+
+   private:
+      mutable AES_256_CTR_XOF m_aes_xof;
 };
 
 }  // namespace Botan