Notify updated devicenames during scanning #429
Conversation
ScanResult.getScanRecord().getDeviceName() returns the most up to date name from the latest scan while ScanResult.getDevice().getName() returns first name found after starting scan
| @@ -2905,6 +2905,9 @@ public void onScanResult(int callbackType, ScanResult result) { | |||
| JSONObject returnObj = new JSONObject(); | |||
|
|
|||
| addDevice(returnObj, result.getDevice()); | |||
| if(result.getScanRecord().getDeviceName() != null){ | |||
| addProperty(returnObj, keyName, result.getScanRecord().getDeviceName().replace("\0", "")); | |||
There was a problem hiding this comment.
What's the replace needed for? Perhaps this should be opt in since it changes the existing behavior
There was a problem hiding this comment.
I'm communicating with a device which padds it's name field with 0x00's. I'm not sure why, but getDevice().getName() filters this by itself while getScanRecord().getDeviceName() does not, resulting in strange behaviour on the JS side.
Better solutions are appreciated off course.
There was a problem hiding this comment.
If this is dependent on a specific device, I think it should be done on the client side.
There was a problem hiding this comment.
I think that the behaviour of the plugin should not change, so since getDevice().getName() skips the zeroes, I think the result of getScanRecord().getDeviceName() should be filtered to obtain the same result.
There was a problem hiding this comment.
Ahh I see what you're saying. The empty stay is just right padded with 0x00? I think that behavior is fine then.
|
Will try to make a release tonight. |
|
Thanks, this solves #428 |
ScanResult.getScanRecord().getDeviceName() returns the most up to date name from the latest scan while ScanResult.getDevice().getName() returns first name found after starting scan