Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: accept list of vcenter dcs #63

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

swarren83
Copy link

@swarren83 swarren83 commented Dec 5, 2023

Pull Request Checklist

  • Any new images or tags consumed by charts has been added here
  • Chart version has been incremented (if necessary)
  • That helm lint and pack run successfully on the chart.
  • Deployment of the chart has been tested and verified that it functions as expected.
  • Changes to scripting or CI config have been tested to the best of your ability

Types of Change

Feature: Accept an array of vCenter.datacenters instead of a string array.

Linked Issues

Additional Notes

helm lint charts/rancher-vsphere-cpi 
==> Linting charts/rancher-vsphere-cpi

1 chart(s) linted, 0 chart(s) failed
values.yaml
-----------
vCenter:
  host: "foo"
  datacenters: ["/foo-bar","/baz-foo"]

helm template charts/rancher-vsphere-cpi | yq '. | select(.kind=="ConfigMap")'
# Source: rancher-vsphere-cpi/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: vsphere-cloud-config
  labels:
    vsphere-cpi-infra: config
    component: rancher-vsphere-cpi-cloud-controller-manager
    app.kubernetes.io/version: "1.27.0"
    app.kubernetes.io/managed-by: Helm
    helm.sh/chart: rancher-vsphere-cpi-1.7.0
  namespace: default
data:
  vsphere.yaml: |
    # Global properties in this section will be used for all specified vCenters unless overriden in VirtualCenter section.

    global:
      secretName: "vsphere-cpi-creds"
      secretNamespace: "default"
      port: 443
      insecureFlag: true

    # vcenter section
    vcenter:
      "foo":
        server: "foo"
        datacenters:
          - "/foo-bar"
          - "/baz-foo"

After the PR is merged

Once the PR is merged, typically upon a new release, the necessary teams will be notified via Slack hook to perform the RKE2 Charts and RKE2 changes. Any developer working on this issue is not responsible for updating RKE2 Charts or RKE2.

@swarren83 swarren83 changed the title Feat/accept list of vcenter dcs Feat: accept list of vcenter dcs Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant