Workload updates #76
Merged
Workload updates #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susesgartner
force-pushed
the
verify-update
branch
4 times, most recently
from
3a74d7b to
fe5c585
Compare
susesgartner
force-pushed
the
verify-update
branch
11 times, most recently
from
a95ce54 to
51b9ec8
Compare
susesgartner
force-pushed
the
verify-update
branch
3 times, most recently
from
6a6d5be to
ee61f4f
Compare
susesgartner
force-pushed
the
verify-update
branch
from
ee61f4f to
d19c811
Compare
Update verify.go updates update tests Update setMultiCluster.go update with workloads update psact Update verify.go Update verify.go go mod update Update Dockerfile Update verify.go add sleep update go.mod and some go docs update with timeout update update order of ops Update verify.go Update verify.go Add temp fix Update registries_test.go Update registries_test.go
susesgartner
force-pushed
the
verify-update
branch
from
d19c811 to
7cbb1bc
Compare
Josh-Diamond
approved these changes
Jan 29, 2025
markusewalker
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to rework the validations performed across all our tests:
Additional notes: Whenever we consolidate multi-cluster provisioning I would like to remove the need to return the clusterNames (which are generated in the provisioning logic) and instead generate the names in a helper. The idea would be similar in concept to permutations except instead of generating configs it would simply alter a config to make certain fields unique i.e names, identifiers.... this would split our config file building logic (permutations, uniquifying, and default settings) from our creation logic. Overall this would be a nice gain in modularity.