Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed nodes argument at rke_cluster resource to properly get updated #239

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Fixed nodes argument at rke_cluster resource to properly get updated #239

merged 2 commits into from
Aug 20, 2020

Conversation

rawmind0
Copy link
Contributor

@rawmind0 rawmind0 commented Aug 17, 2020 •
edited
Loading

Closes #229 #225

Requires PR #237

@rawmind0 rawmind0 self-assigned this Aug 17, 2020
@rawmind0 rawmind0 added the bug Something isn't working label Aug 17, 2020
@rawmind0 rawmind0 mentioned this pull request Aug 17, 2020
Closed
@rawmind0 rawmind0 force-pushed the nodes branch 2 times, most recently from 086599c to 6651327 Compare August 17, 2020 21:53
@rawmind0 rawmind0 requested a review from paraglade August 17, 2020 22:01
@rawmind0 rawmind0 mentioned this pull request Aug 19, 2020
Merged
@rawmind0 rawmind0 added the dependencies This issue or pull requests has external dependencies label Aug 19, 2020
@rawmind0 rawmind0 mentioned this pull request Aug 19, 2020
Closed
paraglade
paraglade approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@paraglade paraglade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@rawmind0 rawmind0 merged commit 948ab2c into rancher:master Aug 20, 2020
@rawmind0 rawmind0 mentioned this pull request Aug 20, 2020
Closed
@anGie44 anGie44 mentioned this pull request Sep 18, 2020
Closed
@bizmate bizmate mentioned this pull request Sep 18, 2020
Closed
@rawmind0 rawmind0 deleted the nodes branch November 12, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paraglade paraglade paraglade approved these changes

Assignees

@rawmind0 rawmind0

Labels
bug Something isn't working dependencies This issue or pull requests has external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It is not clear how to correctly add and remove nodes from rke cluster
2 participants
@rawmind0 @paraglade