Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update wording for amazonec2_config userdata #941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkeightley
Copy link
Contributor

It appears this argument does not read a file, and expects userdata inline

It appears this argument does not read a file, and expects userdata inline
@dkeightley dkeightley changed the title Update wording for amazonec2_config userdata [Docs] Update wording for amazonec2_config userdata May 30, 2022
@a-blender a-blender self-requested a review August 2, 2023 19:12
Copy link
Contributor

@a-blender a-blender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userdata is located in the docs in many more places than just this one line. To update the docs, please

  • Add your test steps to verify that user data only expects data inline and not via a file. Did you just see this behavior with EC2? With other providers?
  • Update all instances of this field in the docs.

@kkaempf
Copy link
Contributor

kkaempf commented Dec 8, 2023

closing stale PRs.
If you still intend to work on this, please reopen.

@kkaempf kkaempf closed this Dec 8, 2023
@dkeightley
Copy link
Contributor Author

dkeightley commented Dec 10, 2023

Sorry, just got alerted to this.

userdata is located in the docs in many more places than just this one line. To update the docs, please

* Add your test steps to verify that `user data` only expects data inline and not via a file. Did you just see this behavior with EC2? With other providers?

If my interpretation is accurate, the provider is not copying the file or contents, but passing the value as a string to the API, so providing a file would be unusual, the API schema appears to align.

Here's an example I built some time back: https://gist.github.com/dkeightley/6e8e3de9567e2ca9c63294171d45c828#file-main-tf-L70-L76

* Update all instances of this field in the docs.

I'll check through the other node drivers if you agree this is a desired change @a-blender?

@dkeightley
Copy link
Contributor Author

Reopening as per the above, please close if this change is not desired.

@dkeightley dkeightley reopened this Dec 13, 2023
@kkaempf kkaempf requested a review from snasovich December 13, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants