-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Norman Proxy Support #218
Norman Proxy Support #218
Conversation
Hi @jordanjean, have you modified directly the vendor file?? I think this change is not done at norman repo. The proper way to do it should be submit this PR at norman repo and then update module version here. |
Hi @rawmind0, yes I opened a PR at the Norman repo (rancher/norman#329). Once it is merged, I could update the module version and remove the changes made to the vendor file. |
Cool, thanks. |
5cbd842
to
a2ab15e
Compare
90d4eba
to
c79630b
Compare
Hi, the PR introducing proxy support for the Norman dependency is merged. I updated the module version here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordanjean , you'd need to also update vendor files and include them in the PR, GO111MODULE=on go mod vendor
c79630b
to
4fd50eb
Compare
@rawmind0, vendor files updated. |
@jordanjean , could you please resolve conflicts?? |
4fd50eb
to
beaa3e3
Compare
@rawmind0, for sure, branch rebased ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jordanjean
LGTM
This Pull Request introduces proxy support for the Rancher Norman API.