Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra return in machine template, back port v5 (#1400) #1401

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

matttrach
Copy link
Collaborator

backport #1400 to release/v5 addressing #1398

Signed-off-by: matttrach [email protected]
(cherry picked from commit 1792a32)

Signed-off-by: matttrach <[email protected]>
(cherry picked from commit 1792a32)
@matttrach matttrach requested a review from jiaqiluo September 6, 2024 16:29
@matttrach matttrach self-assigned this Sep 6, 2024
@matttrach matttrach added this to the September Release 2024 milestone Sep 6, 2024
@matttrach matttrach changed the title fix: remove extra return in machine template (#1400) fix: remove extra return in machine template, back port v5 (#1400) Sep 6, 2024
Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Backport PR needs only 1 approval for merging.

@matttrach matttrach merged commit d9facff into rancher:release/v5 Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants