-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add provider specific proxy option #1237
base: master
Are you sure you want to change the base?
Conversation
closing stale PRs. |
I am waiting for rancher/norman#453 to be merged, this draft PR is working (we are running with a self compiled provider binary based on this patch as local override). @kkaempf , do you have any idea who we could ping with regards to that rancher/norman PR to get this moving along? |
rancher/norman#453 has been merged, but the go dependencies need to be updated. Could you please do that and re-push? |
@ericpromislow as norman now requires go 1.22 and terraform-provider-rancher2 is on 1.19, perhaps it is better to bump the norman dep in a separate PR?
From the drone ci logs:
So, I assume bumping norman also requires some changes to the ci steps. |
@sboschman Thanks, I'll have a look |
Could you pull this out of draft mode so I can see what happens in CI? This repo doesn't have a |
Also I noticed the following problems with this repo with go 1.22 on both macos and ubuntu:
AFAIK this variable is no longer needed. After I pull out the two
|
Issue: #982
Depends on pr rancher/norman #453
As this pr depends on
norman
it is a draft pr, till we can get the required change merged intonorman
.Problem
Currently a proxy url can only be set as environment variable, which is used by all providers in the terraform run. If only Rancher requests should be proxied, a provider based proxy setting is required.
Solution
Added extra provider config option
proxy_url
to set a proxy server to use to connect to the Rancher instance.Testing
Engineering Testing
Manual Testing
Locally tested to run a
tf plan/apply
with a Rancher instance behind a Cloudflare Zero Trust tunnel, requiring a localhost proxy to connect and authenticate to Cloudflare.Automated Testing
Added testcases to check the validation of the
proxy_url
config. It should only accept parsable http, https or socks5 urls.QA Testing Considerations
Regressions Considerations