change default ubuntu image from DO #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakefhyde
approved these changes
Aug 31, 2023
a-blender
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
@felipe-colussi Prov an RKE cluster on DO didn't give you any ssh/networking issues like you saw before? Not sure if the fix for this is a fix for what you were seeing a few days ago. Otherwise great catch!
Nop, that was happening on AWS, so I swapped to DO and got this image error :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1215
Problem
Wile testing the migration of SDK to SDK2 I noticed that the default image for DO is no longer valid.
[tf-do-image.zip](https://github.com/rancher/terraform-provider-rancher2/files/12486407/tf-do-image.zip) Error creating machine: Error in driver during machine creation: POST https://api.digitalocean.com/v2/droplets: 422 You specified an invalid image for Droplet creation.After checking DO only supports ubuntu 20 and 22.
Solution
Update the DO default image to: ubuntu-22-04-x64
Testing
Engineering Testing
Manual Testing
Using the terraform as it is:
Tried to generate a UBUNTU RKE cluster using the default image. It fails.
Change the image for
ubuntu-22-04-x64, it works.After the change:
I ran the tf with an empty image. It worked.
TF files:
tf-do-image.zip
Automated Testing
I ran the automated tests.
That said I didn't create one to test the "Default" value provided by TF SDK.
QA Testing Considerations
Regressions Considerations