fix: Drop unneeded reorder surpression #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch drops the deprecated flag for output reordering. This causes the output to be ordered properly instead of following the order of the resource list. References: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/sortoptions/#legacy-sorting
|
lgtm, but I'm curious what the problem is with the current ordering? |
brandond
approved these changes
Mar 7, 2024
|
I don't think there is a problem, it's just not the default. This results in the clusterrole, role and clusterrolebinding being created first before the namespace. I think the apiserver figures that out for us already, but with default reordering the Namespace moves to the top and becomes the first object being created. |
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Sep 26, 2024
…0.14.0 ) (minor) (#5496) This PR contains the following updates: | Package | Update | Change | |---|---|---| | docker.io/rancher/system-upgrade-controller | minor | `v0.13.4` -> `v0.14.0` | | [rancher/system-upgrade-controller](https://redirect.github.com/rancher/system-upgrade-controller) | minor | `v0.13.4` -> `v0.14.0` | --- ### Release Notes <details> <summary>rancher/system-upgrade-controller (rancher/system-upgrade-controller)</summary> ### [`v0.14.0`](https://redirect.github.com/rancher/system-upgrade-controller/releases/tag/v0.14.0) [Compare Source](https://redirect.github.com/rancher/system-upgrade-controller/compare/v0.13.4...v0.14.0) ##### What's Changed - fix: Drop unneeded reorder surpression by [@​SISheogorath](https://redirect.github.com/SISheogorath) in [https://github.com/rancher/system-upgrade-controller/pull/296](https://redirect.github.com/rancher/system-upgrade-controller/pull/296) - Update/fix README kustomize command by [@​SISheogorath](https://redirect.github.com/SISheogorath) in [https://github.com/rancher/system-upgrade-controller/pull/297](https://redirect.github.com/rancher/system-upgrade-controller/pull/297) - Add GHA workflows by [@​bfbachmann](https://redirect.github.com/bfbachmann) in [https://github.com/rancher/system-upgrade-controller/pull/311](https://redirect.github.com/rancher/system-upgrade-controller/pull/311) - Upgrade outdated golang dependencies by [@​harsimranmaan](https://redirect.github.com/harsimranmaan) in [https://github.com/rancher/system-upgrade-controller/pull/326](https://redirect.github.com/rancher/system-upgrade-controller/pull/326) - feat: allow pod replacement policy override by [@​buroa](https://redirect.github.com/buroa) in [https://github.com/rancher/system-upgrade-controller/pull/328](https://redirect.github.com/rancher/system-upgrade-controller/pull/328) - fix: system-upgrade-controller-drainer: add missing delete permission for pods in clusterrole by [@​damdo](https://redirect.github.com/damdo) in [https://github.com/rancher/system-upgrade-controller/pull/320](https://redirect.github.com/rancher/system-upgrade-controller/pull/320) - Bump golang.org/x/net from 0.17.0 to 0.23.0 in /pkg/apis by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/rancher/system-upgrade-controller/pull/307](https://redirect.github.com/rancher/system-upgrade-controller/pull/307) - Fix GHA release workflow by [@​brandond](https://redirect.github.com/brandond) in [https://github.com/rancher/system-upgrade-controller/pull/330](https://redirect.github.com/rancher/system-upgrade-controller/pull/330) - Fix image tag by [@​brandond](https://redirect.github.com/brandond) in [https://github.com/rancher/system-upgrade-controller/pull/331](https://redirect.github.com/rancher/system-upgrade-controller/pull/331) - Fix artifact permissions by [@​brandond](https://redirect.github.com/brandond) in [https://github.com/rancher/system-upgrade-controller/pull/332](https://redirect.github.com/rancher/system-upgrade-controller/pull/332) ##### New Contributors - [@​bfbachmann](https://redirect.github.com/bfbachmann) made their first contribution in [https://github.com/rancher/system-upgrade-controller/pull/311](https://redirect.github.com/rancher/system-upgrade-controller/pull/311) - [@​harsimranmaan](https://redirect.github.com/harsimranmaan) made their first contribution in [https://github.com/rancher/system-upgrade-controller/pull/326](https://redirect.github.com/rancher/system-upgrade-controller/pull/326) - [@​damdo](https://redirect.github.com/damdo) made their first contribution in [https://github.com/rancher/system-upgrade-controller/pull/320](https://redirect.github.com/rancher/system-upgrade-controller/pull/320) **Full Changelog**: rancher/system-upgrade-controller@v0.13.4...v0.14.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45NS40IiwidXBkYXRlZEluVmVyIjoiMzguOTUuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL21pbm9yIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch drops the deprecated flag for output reordering. This causes the output to be ordered properly instead of following the order of the resource list.
References:
https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/sortoptions/#legacy-sorting