New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate labels and annotations from plans to jobs #286

Merged

brandond merged 5 commits into rancher:master from sfackler:labels-annotations

Feb 27, 2024

Contributor

sfackler commented Feb 12, 2024 •

edited by zube bot

Loading

The cattle.io filtering seems a bit sketchy - is there a better way to do that?

Closes #160


          Propagate labels and annotations from plans to jobs

12021da

sfackler force-pushed the labels-annotations branch from 149a189 to 12021da Compare

February 12, 2024 23:49

dweomer suggested changes

View reviewed changes

Contributor

dweomer left a comment

This looks alright to me but some tests that demonstrate it working as expected, for both inclusions and exclusions, are a must.


          Add a test

17cdce7

Contributor Author

sfackler commented Feb 13, 2024

Updated!


          Kick CI

b606f1f

Contributor Author

sfackler commented Feb 16, 2024

I think the CI may be a bit broken? The s390x and manifest builds seem to never start running.


          Typo

1b59e45

Member

brandond commented Feb 17, 2024

yes, we no longer have s390x runners; those steps and the s390x manifest need to be removed.


          remove s390x CI steps

882fe65

Contributor Author

sfackler commented Feb 22, 2024

Build's green!

dweomer approved these changes

View reviewed changes

brandond approved these changes

View reviewed changes

sfackler mentioned this pull request

Add a Complete condition to plans #292

Merged

brandond merged commit 3ffd4a3 into rancher:master

1 check passed

sfackler deleted the labels-annotations branch

February 27, 2024 21:43

lumiere-bot bot referenced this pull request in coolguy1771/home-ops


          fix(container): update system upgrade controller group ( v0.13.2 → v0…

7f75e19

….13.3 ) (patch) (#4296)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[docker.io/rancher/system-upgrade-controller](https://togithub.com/rancher/system-upgrade-controller)
| patch | `v0.13.2` -> `v0.13.3` |
|
[rancher/system-upgrade-controller](https://togithub.com/rancher/system-upgrade-controller)
| patch | `v0.13.2` -> `v0.13.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rancher/system-upgrade-controller
(docker.io/rancher/system-upgrade-controller)</summary>

###
[`v0.13.3`](https://togithub.com/rancher/system-upgrade-controller/releases/tag/v0.13.3)

[Compare
Source](https://togithub.com/rancher/system-upgrade-controller/compare/v0.13.2...v0.13.3)

#### What's Changed

- Propagate labels and annotations from plans to jobs by
[@&#8203;sfackler](https://togithub.com/sfackler) in
[https://github.com/rancher/system-upgrade-controller/pull/286](https://togithub.com/rancher/system-upgrade-controller/pull/286)
- Add a Complete condition to plans by
[@&#8203;sfackler](https://togithub.com/sfackler) in
[https://github.com/rancher/system-upgrade-controller/pull/292](https://togithub.com/rancher/system-upgrade-controller/pull/292)
- feat: Reduce permissions for system-upgrade-controller serviceaccount
by [@&#8203;SISheogorath](https://togithub.com/SISheogorath) in
[https://github.com/rancher/system-upgrade-controller/pull/288](https://togithub.com/rancher/system-upgrade-controller/pull/288)
- Bump mods by [@&#8203;brandond](https://togithub.com/brandond) in
[https://github.com/rancher/system-upgrade-controller/pull/293](https://togithub.com/rancher/system-upgrade-controller/pull/293)

#### New Contributors

- [@&#8203;sfackler](https://togithub.com/sfackler) made their first
contribution in
[https://github.com/rancher/system-upgrade-controller/pull/286](https://togithub.com/rancher/system-upgrade-controller/pull/286)
- [@&#8203;SISheogorath](https://togithub.com/SISheogorath) made their
first contribution in
[https://github.com/rancher/system-upgrade-controller/pull/288](https://togithub.com/rancher/system-upgrade-controller/pull/288)

**Full Changelog**:
rancher/system-upgrade-controller@v0.13.2...v0.13.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTkuNyIsInVwZGF0ZWRJblZlciI6IjM3LjIxOS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

lumiere-bot bot referenced this pull request in coolguy1771/home-ops


          fix(container): update docker.io/rancher/system-upgrade-controller ( …

baf7413

…v0.13.2 → v0.13.3 ) (#4295)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[docker.io/rancher/system-upgrade-controller](https://togithub.com/rancher/system-upgrade-controller)
| patch | `v0.13.2` -> `v0.13.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rancher/system-upgrade-controller
(docker.io/rancher/system-upgrade-controller)</summary>

###
[`v0.13.3`](https://togithub.com/rancher/system-upgrade-controller/releases/tag/v0.13.3)

[Compare
Source](https://togithub.com/rancher/system-upgrade-controller/compare/v0.13.2...v0.13.3)

#### What's Changed

- Propagate labels and annotations from plans to jobs by
[@&#8203;sfackler](https://togithub.com/sfackler) in
[https://github.com/rancher/system-upgrade-controller/pull/286](https://togithub.com/rancher/system-upgrade-controller/pull/286)
- Add a Complete condition to plans by
[@&#8203;sfackler](https://togithub.com/sfackler) in
[https://github.com/rancher/system-upgrade-controller/pull/292](https://togithub.com/rancher/system-upgrade-controller/pull/292)
- feat: Reduce permissions for system-upgrade-controller serviceaccount
by [@&#8203;SISheogorath](https://togithub.com/SISheogorath) in
[https://github.com/rancher/system-upgrade-controller/pull/288](https://togithub.com/rancher/system-upgrade-controller/pull/288)
- Bump mods by [@&#8203;brandond](https://togithub.com/brandond) in
[https://github.com/rancher/system-upgrade-controller/pull/293](https://togithub.com/rancher/system-upgrade-controller/pull/293)

#### New Contributors

- [@&#8203;sfackler](https://togithub.com/sfackler) made their first
contribution in
[https://github.com/rancher/system-upgrade-controller/pull/286](https://togithub.com/rancher/system-upgrade-controller/pull/286)
- [@&#8203;SISheogorath](https://togithub.com/SISheogorath) made their
first contribution in
[https://github.com/rancher/system-upgrade-controller/pull/288](https://togithub.com/rancher/system-upgrade-controller/pull/288)

**Full Changelog**:
rancher/system-upgrade-controller@v0.13.2...v0.13.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTkuNyIsInVwZGF0ZWRJblZlciI6IjM3LjIxOS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet