Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rancher-compose] Support for docker-compose v2 syntax? #3973

Closed
crunchtime-ali opened this issue Mar 15, 2016 · 20 comments
Closed

[rancher-compose] Support for docker-compose v2 syntax? #3973

crunchtime-ali opened this issue Mar 15, 2016 · 20 comments
Assignees
Labels
area/rancher-compose kind/feature Issues that represent larger new pieces of functionality, not enhancements to existing functionality status/has-dependency

Comments

@crunchtime-ali
Copy link

Is there a timeline on when the docker-compose v2 file format will be supported?

Rancher Compose Version: 0.7.2
Docker Version: 1.10.3
OS: OS X 10.11.4 Beta

Steps to Reproduce:

docker-compose.yml

version: '2'
services:
  web:
    build: .
    ports:
     - "5000:5000"
    volumes:
     - .:/code
  redis:
    image: redis

then execute:

rancher-compose -p NewApp up

Results:

ERRO[0000] Could not parse config for project newapp : yaml: unmarshal errors:
  line 1: cannot unmarshal !!str `2` into project.RawService
FATA[0000] Failed to read project: yaml: unmarshal errors:
  line 1: cannot unmarshal !!str `2` into project.RawService

Expected:

@deniseschannon
Copy link

Rancher-compose is based on libcompose and libcompose doesn't support it yet.

docker/libcompose#147

@fuhbar
Copy link

fuhbar commented May 2, 2016

@deniseschannon: Apart from the dependency between CLI tool rancher-compose and docker-compose, to which extent are changes necessary to the core (cattle) and ui? Have you already planned these migrational efforts? Just interested to know when version v2 syntax will make it into an official rancher release.

Would be nice to see rancher-compose and docker-compose converge even more. :)

@deniseschannon
Copy link

@fuhbar We'll also need to add in any new parameters into cattle as part of the API as well as when we export docker-compose.yml files for stacks. And yes, there will be obvious UI changes needed to show these new parameters. We do plan on making v2 syntax support in a release in the future.

We have added this issue for cattle tracking to at least start tracking some of the missing fields. I still have to do a full comparison of V1 vs V2 syntax and what else might be missing.

#4708

@pascalandy
Copy link

+1, compose v2 is how my stack runs at the moment.

@django23
Copy link

+1

@pwFoo
Copy link

pwFoo commented May 17, 2016

Following here.
Need --tmpfs (docker/compose#2778) and --group-add (docker/compose#3328) support with.

@composer22
Copy link

composer22 commented May 28, 2016

libcompose is experimental as such Rancher-Compose should be considered experimental by association. Use in production at your own risk.

@bradjones1
Copy link

Looks like this is primarily blocked by libcompose but they are nearing completion on the ticket referenced above.

@deniseschannon deniseschannon added kind/feature Issues that represent larger new pieces of functionality, not enhancements to existing functionality and removed kind/enhancement Issues that improve or augment existing functionality release/future labels Jun 28, 2016
@deniseschannon deniseschannon added this to the Release 1.2.0 milestone Jun 28, 2016
@cabrinoob
Copy link

+1 for this feature. Any release date? I'am using rancher v1.1.0-dev5 and it always seems not to manage v2 syntax of docker-compose.

@deniseschannon
Copy link

@cabrinoob Anything with a milestone is typically in our roadmap. When we add in this feature, we'll also announce it in our release-notes.

@cabrinoob
Copy link

OK, sorry^^

@ghost
Copy link

ghost commented Jul 10, 2016

+1

@crunchtime-ali
Copy link
Author

@deniseschannon: Off-topic: Is there an easy way to view that roadmap? GitHub only shows a single milestone AFAIK.

@deniseschannon
Copy link

@dj-hedgehog We now have project planning pages.

https://github.com/rancher/rancher/wiki/Rancher-1.2.0

@roynasser
Copy link

I realize this has a milestone of 1.2.0 (so I guess around october?), however it also says "resolved" in status label... Is it implemented in any version?

We are using buildargs quite extensively in order to re-use a bunch of images for similar purposes... compose v2 would allow us to go back to using rancher...

@soumyalj
Copy link

Tested the v1.2.0-pre2-rc1. Ran all the rancher-compose-commands related test cases with v2 syntax. Did not find any issues.

@roynasser
Copy link

Great news... will test pre2-rc1 soon :)

@deniseschannon
Copy link

@RVN-BR Please note that we have only tested for services.

We have to introduce volumes and networks.

@roynasser
Copy link

Actually I'm using mostly (or only) build arguments from v2... Havent used volumes or networks... I do use regular links and dependes_on, as well as volumes_from (but have maintained a 1-1 relationship so I dont screw up sidekicks...

@deniseschannon
Copy link

Added in support for v2 services, but created separate issues for v2 volumes (#5714) and v2 networks (#5715).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rancher-compose kind/feature Issues that represent larger new pieces of functionality, not enhancements to existing functionality status/has-dependency
Projects
None yet
Development

No branches or pull requests