Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Support version 2 of compose file #147

Closed
sebgoa opened this issue Feb 8, 2016 · 18 comments
Closed

Support version 2 of compose file #147

sebgoa opened this issue Feb 8, 2016 · 18 comments

Comments

@sebgoa
Copy link

sebgoa commented Feb 8, 2016

Hi, I don't think lib compose can currently parse version 2 compose files.

@vdemeester
Copy link
Collaborator

@Runseb true, it's on the roadmap for v0.2.0 : https://github.com/docker/libcompose/wiki/0.2.0-Milestone-Project-Page 😉

@vdemeester vdemeester added this to the 0.2.0 Trusting Euler milestone Feb 8, 2016
@vdemeester vdemeester changed the title parse version 2 of compose file Support version 2 of compose file Feb 17, 2016
@ngtuna
Copy link

ngtuna commented Mar 19, 2016

Hi @vdemeester , is there any progress on this item ? I'm working on it as well. Considering to add a new ServiceConfigV2 struct for compose file v2 like this. https://gist.github.com/ngtuna/c84d59b497bca62e2e9f

But I found it's not really convenience to maintain two structs of v1 and v2. How's your thought ?

@vdemeester
Copy link
Collaborator

@ngtuna I'm working on this yeah, but no "public" progress right now 😄. I'll ping you for early reviews :)

@F21
Copy link
Contributor

F21 commented Mar 21, 2016

@vdemeester Thank you so much for working on this! Is there any timeline for when this might surface? 😄

@vdemeester
Copy link
Collaborator

@F21 I'm hoping at the end of this week 😉

@koliyo
Copy link

koliyo commented Apr 6, 2016

+1 This is a major issue imo

@mkamlesh
Copy link

mkamlesh commented May 2, 2016

Hello, are there plans to resolve this issue in very near future?

@vdemeester
Copy link
Collaborator

@mkamlesh yes @joshwget (and I) is working on it 😉. Should definitely land for 0.3.0.

@mkamlesh
Copy link

Thanks @vdemeester !! What's the estimated date for 0.3.0 release?

@vdemeester
Copy link
Collaborator

Should be somewhere in June

@mkamlesh
Copy link

Great. Thanks!

@shouze
Copy link

shouze commented May 23, 2016

@vdemeester Hi, looks to be done on your libcompose fork master branch, that's it? How could I help you with @joshwget to make things move forward?

I would love to use asap an upgraded version of libcompose to run v2 compatible services within rancher for example thus closing rancher/rancher#3973

@vdemeester
Copy link
Collaborator

@shouze it's already in current master (parsing and populating the internal struct), but there is still some bugs and stuff that are not supported (like networks and volumes) for now.

@shouze
Copy link

shouze commented May 25, 2016

@vdemeester how can I help on either network and volumes? If you open some issues, this way I could take on it.

@vdemeester
Copy link
Collaborator

@shouze good idea, I'll open one issue for volumes, on for networks. I was going to take networks one first so feel free to work on the volume part 😉

@vdemeester
Copy link
Collaborator

The parsing should be almost OK. What is missing still:

  • Validation as we do on v1 (using schema)
  • Networks & Volumes management, PRs to come from me and @shouze

@shouze
Copy link

shouze commented Jun 2, 2016

@vdemeester I'm a bit late for Volumes but no worry I don't give up ;)

@vdemeester vdemeester self-assigned this Jul 11, 2016
@vdemeester
Copy link
Collaborator

Once #339 is merged, v2 will be support (in 0.3.0, so in less than a week 😉)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants