Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg the helm-locker repo to merge into helm-project-operator repo #94

Closed
mallardduck opened this issue Sep 11, 2024 · 1 comment
Closed

Comments

@mallardduck
Copy link
Member

Per title, this issue is to track phase 1 of our project monitoring re-org project.

Essentially in this step we are re-homing the helm-locker code into the helm-project-operator repo. And the goal is to do so without changing much else that could cause breaking changes at all. So testing/QAing this before we merge is a crucial step to ensure we're not overlooking something.

To test, setup Rancher (ideally 2.10/head) and create a repo:

type: git
url: https://github.com/mallardduck/rancher-charts
branch: prom-reorg-test

Then you will have access to Prometheus Federator 105.0.0-rc.1+up0.4.2 which has these changes incorporated into the image it uses. This can be used to run the QA tests for prom-federator and rancher-project-monitoring. And once validated we should be more confident when merging these reorganization PRs.


The primary PR this is testing is: rancher/helm-project-operator#74
However this waterfalls into: #93
And subsequently the rancher/charts branch mentioned above; however this PR is meant for demo only and will be recreated at merge time. Ideally, these changes will rolling out along side with the 2.10 monitoring rebase.

@pankajsqe
Copy link

Passed : Blocker issue #47155 was resolved and retested. regression test on project-monitoring from prometheus-federator was completed.!

rancher v2.10-head
cluster k3s
prom-fed 105.0.0-rc.1+up0.4.2
charts repo :

Image
Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants