Added logs to cluster extraction #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinJoiner
suggested changes
Mar 24, 2023
controller/cluster_check.go
Outdated
| ns := getValue(obj, "Namespace") | ||
| name := getValue(obj, "Name") | ||
| kind := getValue(obj, "Kind") | ||
| logrus.Debugf("failed to extract cluster that the object [%s:%s] of kind [%s] belongs to", ns, name, kind) |
There was a problem hiding this comment.
nit: I fear that this makes it into production, and a user sees the logs and assumes that something in rancher is failing, causing them to raise a ticket.
Suggested change
| logrus.Debugf("failed to extract cluster that the object [%s:%s] of kind [%s] belongs to", ns, name, kind) | |
| logrus.Debugf("unable to extract cluster that the object [%s:%s] of kind [%s] belongs to", ns, name, kind) |
controller/cluster_check.go
Outdated
| @@ -17,6 +17,8 @@ func ObjectInCluster(cluster string, obj interface{}) bool { | |||
| // Check if the object implements the interface, this is best case and | |||
| // what objects should strive to be | |||
| if o, ok := obj.(ObjectClusterName); ok { | |||
| clusterName := o.ObjClusterName() | |||
| debugLogsClusterExtraction(clusterName, obj) | |||
| return o.ObjClusterName() == cluster | |||
There was a problem hiding this comment.
Suggested change
| return o.ObjClusterName() == cluster | |
| return clusterName == cluster |
|
@KevinJoiner We are trying to figure out how often this happens. If it happens frequently then that is a problem. I don't think spam will be much of an issue since it's debug. The handler also have a built in backoff so it should be throttled. |
cbron
approved these changes
Mar 24, 2023
KevinJoiner
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.