Add unauthorized error check #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramich
reviewed
Nov 12, 2019
httperror/error.go
Outdated
| @@ -120,3 +120,10 @@ func IsConflict(err error) bool { | |||
|
|
|||
| return false | |||
| } | |||
|
|
|||
| func IsUnauthorized(err error) bool { | |||
| if err, ok := err.(*APIError); ok { | |||
There was a problem hiding this comment.
Keep this the same as the other helpers err > apiError. err indicates it's a real error when really it's the value.
rmweir
force-pushed
the
add-unauth-check
branch
from
6435d14 to
8aad789
Compare
mrajashree
reviewed
Nov 13, 2019
httperror/error.go
Outdated
| @@ -120,3 +120,10 @@ func IsConflict(err error) bool { | |||
|
|
|||
| return false | |||
| } | |||
|
|
|||
| func IsUnauthorized(err error) bool { | |||
There was a problem hiding this comment.
should this be IsForbidden instead since it's a 403?
rmweir
force-pushed
the
add-unauth-check
branch
from
8aad789 to
9589f40
Compare
dramich
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.