Add enable function to schema and addFeature functions #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmweir
force-pushed
the
feature-flags-v2
branch
5 times, most recently
from
04e5a84 to
122bc76
Compare
rmweir
changed the title
daxmc99
reviewed
Jun 10, 2019
generator/controller_template.go
Outdated
| @@ -169,6 +189,21 @@ func (c *{{.schema.ID}}Controller) AddClusterScopedHandler(ctx context.Context, | |||
| }) | |||
| } | |||
|
|
|||
| func (c *{{.schema.ID}}Controller) AddClusterScopedFeatureHandler(enabled func() bool, ctx context.Context, name, cluster string, handler {{.schema.CodeName}}HandlerFunc) { | |||
There was a problem hiding this comment.
Is there a specific case this satisfies?
Can a user enable a feature on a per cluster basis?
dramich
reviewed
Jun 11, 2019
generator/controller_template.go
Outdated
| @@ -74,7 +74,9 @@ type {{.schema.CodeName}}Controller interface { | |||
| Informer() cache.SharedIndexInformer | |||
| Lister() {{.schema.CodeName}}Lister | |||
| AddHandler(ctx context.Context, name string, handler {{.schema.CodeName}}HandlerFunc) | |||
| AddFeatureHandler(enabled func() bool, ctx context.Context, name string, sync {{.schema.CodeName}}HandlerFunc) | |||
There was a problem hiding this comment.
context should always be the first arg to a function
Added enable function to schemas. This allows filtering of schemas which is a required part of feature flagging in rancher. Added addFeature functions to controller template for adding handlers that can be disabled if their associated feature is disabled.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related feature
Add feature flags
Rancher PR:
rancher/rancher#20593