Record cluster scoped handlers #277
Conversation
resource/resource.go
Outdated
|
|
||
| // needs to be accessible by both project controllers and mgmt controllers | ||
| var ( | ||
| CleanerFuncMap = struct { |
There was a problem hiding this comment.
change the name of this to be ClusterScopedFinalizerGroupVersionResources
Also, generally, putting the type (ie "Map") in the name of a variable is unnecessary
There was a problem hiding this comment.
add a comment explaining what this variable is used for
There was a problem hiding this comment.
This is technically more than a list of cluster scoped finalizers. This is a set of all rancher generated types.
resource/resource.go
Outdated
| CleanerFuncMap = struct { | ||
| sync.RWMutex | ||
| M map[string]schema.GroupVersionResource | ||
| }{M: make(map[string]schema.GroupVersionResource)} |
There was a problem hiding this comment.
change the map to have a key of GroupVersionResource and bool value
| sync.RWMutex | ||
| M map[string]schema.GroupVersionResource | ||
| }{M: make(map[string]schema.GroupVersionResource)} | ||
| ) |
There was a problem hiding this comment.
We might as well go the extra step and properly protect this map from concurrency issues.
- Make the M lowercase so that it is not publicly exposed.
- add a put method that is wrapped in Lock()
- add a Get function that returns a copy of the map
There was a problem hiding this comment.
rather than a copy of the map, return a list of GVRs
There was a problem hiding this comment.
I think it would be more useful in the future to have the map to check for existence ( O(1) vs O(n) for a list)
Problem: Cluster scoped handlers were not being cleaned up without manually writing garbage collection functions. Solution: All cluster scoped handlers will be recorded in a global map in a generic format so that they can be removed by a generic function.
daxmc99
force-pushed
the
cluster_scoped_gc
branch
from
ae75024 to
bbf450e
Compare
|
LGTM |
Problem: Cluster scoped handlers were not being cleaned up without
manually writing garbage collection functions.
Solution: All cluster scoped handlers will be recorded in a global map
in a generic format so that they can be removed by a generic function.