Track namespaces in options property #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmweir
force-pushed
the
bug/add-ns-filters-dep
branch
4 times, most recently
from
d4ed930 to
2367690
Compare
|
LGTM |
rmweir
force-pushed
the
bug/add-ns-filters-dep
branch
3 times, most recently
from
e4b7116 to
49a37e1
Compare
StrongMonkey
reviewed
Apr 1, 2019
rmweir
force-pushed
the
bug/add-ns-filters-dep
branch
2 times, most recently
from
4e43e75 to
fcbbc90
Compare
Now, identifies and assigns namespaces. Prior, the backend listed items belongng to all namespaces in all projects no matter what because they were not being tracked. This led to longer request times for projects that contained a fraction of total resources. Now, rancher can filter project resource requests; times are improved and largely dependent on resource amount for the given project.
rmweir
force-pushed
the
bug/add-ns-filters-dep
branch
from
69862f5 to
4fcf8aa
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Requests associated with a particular project are not being filtered. Consequently, requests for projects that posses a fraction of total resources are taking longer than necessary to return.
Solution:
Norman now tracks and assigns project namespaces which are necessary for rancher to filter project requests.
Issues:
rancher/rancher#18870
rancher/rancher#18522
rancher/rancher#18295
rancher/rancher#16605