add yaml support #165
Merged
add yaml support #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types/encoder.go
Outdated
| return json.NewEncoder(writer).Encode(v) | ||
| } | ||
|
|
||
| func YamlEncoder(writer io.Writer, v interface{}) error { |
There was a problem hiding this comment.
Change to YAML, not Yaml
parse/parse.go
Outdated
| return "json" | ||
| } | ||
|
|
||
| func isYaml(req *http.Request) bool { | ||
| return req.Header.Get("Accept") == "application/yaml" |
There was a problem hiding this comment.
A client can send multiple Accept headers to say different content types they accept. So you need to see if it's in one of the headers
api/writer/json.go
Outdated
| AddCommonResponseHeader(apiContext) | ||
| apiContext.Response.Header().Set("content-type", "application/json") | ||
| if j.Type == "json" { |
There was a problem hiding this comment.
can the type just have j.ContentType and just set content-type = j.ContentType
api/writer/json.go
Outdated
| @@ -13,26 +12,32 @@ import ( | |||
| "github.com/sirupsen/logrus" | |||
| ) | |||
|
|
|||
| type JSONResponseWriter struct { | |||
| type JSONOrYAMLResponseWriter struct { | |||
There was a problem hiding this comment.
This really has nothing to do with JSONorYaml now. Can you rename to EncodingResponseWriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.