Fix logic for setting annotation based fields #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not drop a field-to-annotation conversion if the value of the field is nil. The user is excplicitly trying to set it to nil - Never delete field annotations, even if they are not in the new map of annotations sent by the user. - Prevent the modification of the creatorId field, which is a special case field that should be considered protected
|
addresses rancher/rancher#12564 (but will need pulled into rancher) |
|
LGTM |
jordanjean
pushed a commit
to jordanjean/norman
that referenced
this pull request
Jan 7, 2020
Added rancher2_alert_group and rancher2_alert_rule datasource and resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nil. The user is excplicitly trying to set it to nil
annotations sent by the user.
field that should be considered protected