Use helper method

rancher · Dec 14, 2017 · b6df901 · b6df901
1 parent 23d630f
commit b6df901
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/lifecycle/object.go b/lifecycle/object.go
@@ -125,10 +125,8 @@ func (o *objectLifecycleAdapter) create(metadata metav1.Object, obj runtime.Obje
 	} else if newObj != nil {
 		_, err = o.objectClient.Update(metadata.GetName(), newObj)
 		return false, err
-	} else {
-		_, err = o.objectClient.Update(metadata.GetName(), obj)
-		return false, err
 	}
 
-	return false, nil
+	_, err = o.objectClient.Update(metadata.GetName(), obj)
+	return false, err
 }
diff --git a/store/crd/crd_store.go b/store/crd/crd_store.go
@@ -2,7 +2,6 @@ package crd
 
 import (
 	"context"
-	"net/http"
 	"strings"
 	"time"
 
@@ -111,7 +110,7 @@ func (c *Store) AddSchemas(ctx context.Context, schemas ...*types.Schema) error
 	var allSchemas []*types.Schema
 
 	for _, schema := range schemas {
-		if schema.Store != nil || !contains(schema.CollectionMethods, http.MethodGet) {
+		if schema.Store != nil || !schema.CanList() {
 			continue
 		}