Merge pull request #291 from ukinau/Configure-WebSocket-Handshake

Configure HandshakeTimeout in websocket.Dialer
rancher · Jul 4, 2019 · 043a1c9 · 043a1c9
2 parents 2da1bd2 + 129bbd3
commit 043a1c9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/clientbase/common.go b/clientbase/common.go
@@ -277,7 +277,7 @@ func NewAPIClient(opts *ClientOpts) (APIBaseClient, error) {
 	result.Ops = &APIOperations{
 		Opts:   opts,
 		Client: client,
-		Dialer: &websocket.Dialer{},
+		Dialer: &websocket.Dialer{HandshakeTimeout: 10 * time.Second},
 		Types:  result.Types,
 	}
 

diff --git a/pkg/remotedialer/client.go b/pkg/remotedialer/client.go
@@ -22,7 +22,7 @@ func connectToProxy(proxyURL string, headers http.Header, auth ConnectAuthorizer
 	logrus.WithField("url", proxyURL).Info("Connecting to proxy")
 
 	if dialer == nil {
-		dialer = &websocket.Dialer{}
+		dialer = &websocket.Dialer{HandshakeTimeout: 10 * time.Second}
 	}
 	ws, _, err := dialer.Dial(proxyURL, headers)
 	if err != nil {

diff --git a/pkg/remotedialer/peer.go b/pkg/remotedialer/peer.go
@@ -79,6 +79,7 @@ func (p *peer) start(ctx context.Context, s *Server) {
 		TLSClientConfig: &tls.Config{
 			InsecureSkipVerify: true,
 		},
+		HandshakeTimeout: 10 * time.Second,
 	}
 
 outer:
-Original file line number
+Diff line change
@@ Expand Up / @@ -79,6 +79,7 @@ func (p *peer) start(ctx context.Context, s *Server) { @@
     		TLSClientConfig: &tls.Config{
     			InsecureSkipVerify: true,
     		},
+    		HandshakeTimeout: 10 * time.Second,
     	}
     outer:
@@ Expand Down @@