Do not return error in ProjectGetter when namespaces don't exist #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ProjectGetter methods are called by the indexers, if the methods return errors on namespaces not existing, it can result in a panic due to the default behavior of the [thread_safe_store.go](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/cache/thread_safe_store.go#L148-L153). This would only happen in situations where there's an extremely large amount of load on the Prometheus Federator, since normally indexing is a fairly quick operation that should happen before a namespace can be created and deleted (unless the controllers are heavily backed up in processing).
geethub97
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: rancher/rancher#41214
Since ProjectGetter methods are called by the indexers, if the methods return errors on namespaces not existing, it can result in a panic due to the default behavior of the thread_safe_store.go.
This would only happen in situations where there's an extremely large amount of load on the Prometheus Federator, since normally indexing is a fairly quick operation that should happen before a namespace can be created and deleted (unless the controllers are heavily backed up in processing).