Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rancher/shell rc version to use SLE-BCI base image #16

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Update rancher/shell rc version to use SLE-BCI base image #16

merged 1 commit into from
Jul 6, 2022

Conversation

macedogm
Copy link
Member

@macedogm macedogm requested a review from aiyengar2 as a code owner June 22, 2022 14:27
@macedogm macedogm mentioned this pull request Jun 22, 2022
Closed
8 tasks
@macedogm
Copy link
Member Author

@aiyengar2 please let me know if I need to bump the version of the chart also. Thanks!

aiyengar2
aiyengar2 suggested changes Jun 23, 2022
View reviewed changes
Copy link

@aiyengar2 aiyengar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only need to bump the rancher/shell image, we only need to bump the version and the rancher/shell tag.

charts/helm-project-operator/values.yaml Outdated Show resolved Hide resolved
charts/helm-project-operator/Chart.yaml Outdated Show resolved Hide resolved
aiyengar2
aiyengar2 approved these changes Jun 27, 2022
View reviewed changes
Copy link

@aiyengar2 aiyengar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need a followup PR to bump the rancher/shell image to a non-RC version before release.

charts/helm-project-operator/values.yaml Outdated Show resolved Hide resolved
@macedogm macedogm marked this pull request as draft June 30, 2022 17:01
@macedogm
Bump rancher/shell image version
5d26cc3 
Signed-off-by: Guilherme Macedo <[email protected]>
@macedogm macedogm marked this pull request as ready for review July 1, 2022 09:23
@macedogm
Copy link
Member Author

macedogm commented Jul 1, 2022

I moving the version to rc again, in order to follow our best practices. Before the next version of Rancher is released, I'll then move it to a non-rc version.

aiyengar2
aiyengar2 approved these changes Jul 5, 2022
View reviewed changes
Copy link

@aiyengar2 aiyengar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to make another PR to change from the RC version

@macedogm
Copy link
Member Author

macedogm commented Jul 6, 2022

@aiyengar2 the PR to a non-rc version is in draft mode for now - #18.

@macedogm macedogm changed the title Update rancher/shell version to use SLE-BCI base image Update rancher/shell rc version to use SLE-BCI base image Jul 6, 2022
@aiyengar2 aiyengar2 merged commit d05777e into rancher:main Jul 6, 2022
@macedogm macedogm deleted the patch-1 branch July 6, 2022 15:01
@macedogm macedogm mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiyengar2 aiyengar2 aiyengar2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macedogm @aiyengar2