Use norman:"pointer" for nullable fields #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opt into new "pointer" field attribute from norman that will convert any type to a pointer in the generated client code. The generated client code includes "omitempty" JSON tags, which means that for maps and slices, unset and empty values are both sent to the server as unset, which breaks the cluster create validation. With this change, there's now a difference between a nil value and an empty allocated map or slice in the client code. Strings can now also use this attribute instead of the "nullablestrings" type (a85378a/2450a6e).
cmurphy
changed the title
cmurphy
changed the title
thedadams
approved these changes
Jun 10, 2021
cbron
approved these changes
Jun 11, 2021
cbron
reviewed
Jun 11, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opt into new "pointer" field attribute from norman that will convert any
type to a pointer in the generated client code. The generated client code
includes "omitempty" JSON tags, which means that for maps and slices,
unset and empty values are both sent to the server as unset, which
breaks the cluster create validation. With this change, there's now a
difference between a nil value and an empty allocated map or slice in the
client code. Strings can now also use this attribute instead of the
"nullablestrings" type (a85378a/2450a6e).
Depends on rancher/norman#400
rancher/rancher#32553
rancher/rancher#32440