Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RKE cluster being shown as Imported #9868

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Oct 6, 2023

Summary

Fixes #6836

We were not identifying RKE1 clusters correctly.

Occurred changes and/or fixed issues

Changed the way we identify cluster provisioner type to recognize RKE1 clusters correctly and moved the logic to determine if cluster is imported from the Cluster Provider component to the model for better consistency.

Technical notes summary

Areas or cases that should be tested

Cluster management and Home pages should be showing correct "provider" field for each cluster.
Cluster edit should be showing correct fields.

Tested using Chrome 117.0.5938.132
Tested localy:
RKE1 is showing correct info as local and as imported clusters.
K3s is showing correct info as local, created through UI and imported clusters.
RKE2 is showing correct info as local and imported clusters.
AKS is showing correct info as created and imported cluster.

Areas which could experience regressions

Cluster edit might be affected.

Screenshot/Video

Screenshot 2023-10-05 at 3 24 06 PM

@momesgin
Copy link
Member

momesgin commented Oct 6, 2023

@eva-vashkevich Just curious what happens to imported k3s clusters, as of my understanding provisioner() would return ‘k3s’, then isImported() would return false, and consequently isImportedK3s() would also return false, is this intentional?

I actually just read the old comment about the workaround, so based on that isImported() would probably return true

@eva-vashkevich
Copy link
Member Author

@momesgin I've checked and it does identify imported k3 correctly, though your comment made me re-check rke2 case and I was missing identifying DO correctly, so thank you.

@momesgin
Copy link
Member

momesgin commented Oct 6, 2023

@momesgin I've checked and it does identify imported k3 correctly, though your comment made me re-check rke2 case and I was missing identifying DO correctly, so thank you.

happy that it helped somehow 😆

@eva-vashkevich eva-vashkevich merged commit 6d4f75a into rancher:master Nov 1, 2023
8 checks passed
@eva-vashkevich eva-vashkevich deleted the iss6836 branch November 1, 2023 20:02
yonasberhe23 pushed a commit to yonasberhe23/dashboard that referenced this pull request Dec 20, 2023
yonasberhe23 pushed a commit to yonasberhe23/dashboard that referenced this pull request Jan 26, 2024
yonasberhe23 pushed a commit to yonasberhe23/dashboard that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider field on Imported clusters states "Imported" instead of cluster type
3 participants