Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of rancher telemetry #12614

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adamkpickering
Copy link

@adamkpickering adamkpickering commented Nov 14, 2024

Summary

Fixes: #12639

This PR removes code related to telemetry. This removal is planned for 2.11. Related PRs:

The JIRA issue for this is SURE-9295.

I am not super familiar with this repository so if there is anything that needs changing please let me know. But I think this should be fairly straightforward.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.11.0 milestone Nov 15, 2024
@richard-cox
Copy link
Member

Note for whoever picks this up, we should review this from a UX and automated test perspective as well as functional and code.

@rancher-max Should there also be UI QA on the changes?

@adamkpickering Feel free to reference jira as SURE-x

@nwmac
Copy link
Member

nwmac commented Nov 25, 2024

@adamkpickering So, there will be no telemetry in 2.11, is that right?

I think the only thing we have in the UI is the checkbox on the setup screen to allow users to opt-out of telemetry - is this what we need to remove from the UI?

@adamkpickering
Copy link
Author

@adamkpickering So, there will be no telemetry in 2.11, is that right?

Yes that is right.

I think the only thing we have in the UI is the checkbox on the setup screen to allow users to opt-out of telemetry - is this what we need to remove from the UI?

I believe so. The only use of the telemetry we are getting rid of was in multi-cluster apps (pkg/multiclustermanager in rancher/rancher), which are now deprecated. That being said, I'm not super familiar with rancher/dashboard, so I may have missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mentions of rancher telemetry
4 participants