fixed some console errors for standard user #12479
Open
+65
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rak-phillip
requested changes
Nov 13, 2024
Comment on lines
+215
to
+231
| try { | ||
| model = await store.dispatch(`${ inStore }/clone`, { resource: liveModel }); | ||
| } catch (e) { | ||
| this.errors.push(e); | ||
| } | ||
| } | ||
| try { | ||
| initialModel = await store.dispatch(`${ inStore }/clone`, { resource: liveModel }); | ||
| } catch (e) { | ||
| this.errors.push(e); | ||
| } | ||
|
|
||
| initialModel = await store.dispatch(`${ inStore }/clone`, { resource: liveModel }); | ||
|
|
||
| if ( as === _YAML ) { | ||
| yaml = await getYaml(this.$store, liveModel); | ||
| try { | ||
| yaml = await getYaml(this.$store, liveModel); | ||
| } catch (e) { | ||
| this.errors.push(e); | ||
| } |
There was a problem hiding this comment.
It looks like we can wrap all of these statements into a single try...catch block:
try {
if (realMode === _VIEW) {
model = liveModel;
} else {
model = await store.dispatch(`${ inStore }/clone`, { resource: liveModel });
}
initialModel = await store.dispatch(`${ inStore }/clone`, { resource: liveModel });
if ( as === _YAML ) {
yaml = await getYaml(this.$store, liveModel);
}
} catch (e) {
this.errors.push(e);
}
| model = await store.dispatch(`${ inStore }/cleanForDetail`, model); | ||
| try { | ||
| model = await store.dispatch(`${ inStore }/cleanForDetail`, model); | ||
| } catch (e) {} |
There was a problem hiding this comment.
Are we intentionally performing a noop in the catch block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12478
Added some error catching to
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Create a new standard user with this custom roles:
{ resource: "fleetworkspaces", verbs: ["create", "delete", "get", "list", "patch", "update", "watch"]},
{ resource: "gitrepos", verbs: ["list"]},
{ resource: "bundles", verbs: ["create", "delete", "get", "list", "patch", "update", "watch"]},
Log in as this user.
Going to the following pages shouldn't throw any errors in the console:
Cluster management -> Advanced -> Pod Security Admissions
Cluster management -> Drivers -> Node Drivers
Continuous delivery -> Git repos -> Edit YAML for existing git repo should open with an error banner
Areas which could experience regressions
None
Screenshot/Video
Checklist