Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate breaking changes between Rancher Dashboard and Extensions using Vue3 #11049

Closed
cnotv opened this issue May 17, 2024 · 3 comments
Closed
Assignees
Labels
area/extensions area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/tech-debt Technical debt QA/None
Milestone

Comments

@cnotv
Copy link
Contributor

cnotv commented May 17, 2024

Description

To avoid issues for all our customers upgrading Rancher, we must ensure that the upgrade process is not going to break their instances.

This includes cases where:

  • Upgrade of Rancher to Vue3 while using Vue2 extensions
  • Vue2 extensions are present in a Vue3 Rancher instance
  • Vue2 Rancher version with Vue3 extensions

@nwmac Could we make it clear how we ensure avoiding issues for these cases?
Before the release, we will need to make these tests.

Context

While investigating how the Rancher dashboard is initialized, it seemed clear that there are possible issues with the way the same code is used by the extension due to the installation of plugins, directives, and so on.

This may be extended to any other breaking change between Vue2 and Vue3 syntax.

Implementation issue: #10660

@cnotv cnotv added this to the v2.10.0 milestone May 17, 2024
@cnotv cnotv self-assigned this May 17, 2024
@cnotv cnotv changed the title Investigate possible issue in breaking existing instances of Rancher after upgrade to version with Vue3 Investigate breaking changes between Rancher and extensions with Vue3 May 21, 2024
@cnotv cnotv changed the title Investigate breaking changes between Rancher and extensions with Vue3 Investigate breaking changes between Rancher Dashboard and Extensions using Vue3 May 22, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@gaktive gaktive modified the milestones: v2.11.0, v2.10.0 Jul 4, 2024
@gaktive
Copy link
Member

gaktive commented Jul 4, 2024

Can we collapse #10660 into this ticket? @nwmac & I are planning out 2.10.0 and these two sound like they should be done at the same time, otherwise this one sounds not as actionable as the prevention one.

@cnotv
Copy link
Contributor Author

cnotv commented Jul 4, 2024

As I've written in the description of #10660:

Note: This is going to be part of the outcome for #11049

This means that someone has to plan how to deal with the extension and write it somewhere, so we are aware of it.
As last time I've been talking with @nwmac, there was a mechanism to be used in 2.9.0 with another breaking change which can be used as PoC.
If that is going to work, we can close accordingly issues:

@cnotv cnotv added the area/vue3 Bugs and technical debts as outcome to the Vue3 migration label Sep 2, 2024
@cnotv cnotv removed their assignment Sep 11, 2024
@aalves08
Copy link
Member

aalves08 commented Oct 9, 2024

I think this can be closed with the implementation of a proper gating mechanism as per #12071

@aalves08 aalves08 closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extensions area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/tech-debt Technical debt QA/None
Projects
None yet
Development

No branches or pull requests

5 participants