-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.9] rancher-monitoring: add ScrapeConfig CRD #3552
[dev-v2.9] rancher-monitoring: add ScrapeConfig CRD #3552
Conversation
Signed-off-by: Charles Decoux <[email protected]>
Signed-off-by: Charles Decoux <[email protected]>
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
@Carlotronics can you give us some more context? Is this causing issues on your system, point us to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the docs
ScrapeConfig CRD :
Starting with prometheus-operator v0.65.x, one can use the ScrapeConfig CRD to > scrape targets external to the Kubernetes cluster or create scrape configurations that are not possible with the higher level ServiceMonitor/Probe/PodMonitor resources.
Which is supported, since we are using prometheus-operator:v0.65.1
, but its absent from the upstream chart we use kube-prometheus-stack-45.31.1
, taking a quick glance at the upstream chart commit history, these configs were added in around version 48.x
which contains breaking changes to how the chart manages CRDs. So likely these will be supported during our next upgrade of the operator : rancher/rancher#44614
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
|
Problem
ScrapeConfig CRD is provided in prometheus charts but missing in rancher monitoring.
Solution
Add ScrapeConfig CRD